<html>
<head><meta charset="utf-8"><title>Reviews · t-compiler/rust-analyzer · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/index.html">t-compiler/rust-analyzer</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Reviews.html">Reviews</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="200546619"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Reviews/near/200546619" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Reviews.html#200546619">(Jun 11 2020 at 13:51)</a>:</h4>
<p>Good morning <span class="user-mention" data-user-id="133169">@matklad</span> ! I was curious if there's anything else I need to do for <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4587">https://github.com/rust-analyzer/rust-analyzer/pull/4587</a> or <a href="https://github.com/rust-analyzer/rust-analyzer/pull/4743">https://github.com/rust-analyzer/rust-analyzer/pull/4743</a>. I wasn't sure how often I should try to rebase to keep it up to date in case that's messing up the reviews (losing comment context). I also didn't want to pester anyone by hitting the request review every few days. For this project at least, how often should I ping for an update?</p>



<a name="200546702"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Reviews/near/200546702" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Reviews.html#200546702">(Jun 11 2020 at 13:52)</a>:</h4>
<p>I'm also in no rush here. They're simple and small enough to maintain for a while</p>



<a name="200546796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Reviews/near/200546796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Reviews.html#200546796">(Jun 11 2020 at 13:53)</a>:</h4>
<p>Yeah, I didn't have a chance to review those properly yet (have been busy with rewriting the VFS)</p>



<a name="200546947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Reviews/near/200546947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Reviews.html#200546947">(Jun 11 2020 at 13:54)</a>:</h4>
<p>No worries, I'll circle back in a while then. Any issue with rebasing when conflicts come up?</p>



<a name="200547189"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Reviews/near/200547189" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> matklad <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Reviews.html#200547189">(Jun 11 2020 at 13:56)</a>:</h4>
<p>No, we actually prefer rebase approach</p>



<a name="200547267"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/185405-t-compiler/rust-analyzer/topic/Reviews/near/200547267" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Paul Faria <a href="https://rust-lang.github.io/zulip_archive/stream/185405-t-compiler/rust-analyzer/topic/Reviews.html#200547267">(Jun 11 2020 at 13:57)</a>:</h4>
<p>Ok, sounds good. Thanks for the quick respone!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>